Reply to: Code reviews

[NotAllThere]

...

Why don't people fix mistakes when they see them?!

Because they then get crucified by the forum regulars.

[MyUserName]

As we're on the topic of tulipy code and maintenance, etc - here's a gem of a javadoc for a class I just came across:

/**
* Retrieves disputed payments. Inaccurately named, since it is both
* used by the ixxxxxxxx and the xxxxxxxxx!
*
* @author xxxxxxxx
*/


Why don't people fix mistakes when they see them?!

I would fix more but beating people to death is illegal

[SpontaneousOrder]

As we're on the topic of tulipy code and maintenance, etc - here's a gem of a javadoc for a class I just came across:

/**
* Retrieves disputed payments. Inaccurately named, since it is both
* used by the ixxxxxxxx and the xxxxxxxxx!
*
* @author xxxxxxxx
*/


Why don't people fix mistakes when they see them?!

[MyUserName]

but that means you have to think. We want a simple answer which doesn't require thinking that we can take the mickey out of...

Sorry, wrong forum.

I meant that you should always inherit from a bass class and also add the base class as a member or you are clearly a cretin who should not be allowed near a keyboard - and NO! I don't care if you language does not support inheritance.

[eek]

How about 'use inheritance when it is appropriate and use composition when it is appropriate'?

but that means you have to think. We want a simple answer which doesn't require thinking that we can take the mickey out of...

[MyUserName]

How about 'use inheritance when it is appropriate and use composition when it is appropriate'?

[d000hg]

"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.

Being told not to do it is just plain daft, when nearly every class in the Java libraries inherits from something (if it is Java we're talking). Probably "if you're not sure, composite" is better advice.

[SpontaneousOrder]

"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.

You mean "it usually ends up a mess" when used inappropriately? I'm not sure we should use yourself as the lowest common denominator of a developer's ability. Otherwise I'd better go and find a plastic lid with a spout on it for my coffee.

[SpontaneousOrder]

Well you can talk the talk but none of that squares with what you wrote in this thread where you went off and rewrote some stuff on your own

I spent 2 or 3 hours working, and then my code was reviewed (and approved btw). How does that not square?

[minestrone]

Word to the wise, son. When you're in a hole, stop digging.

"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.

[minestrone]

With any luck in an Agile team you'll only have 1 numpty out of 5 or 6 developers. Pair programming and rotating developers among different aspects of the code base (rather than having guys sitting in silos) should mean apart from getting a team with all-round knowledge of the system as a whole, you also get to keep some quality control.

You can still do the same on a non-agile project, so I'd suggest your example is more down to poor project management/company culture than anything else. Why would you let a single guy loose on his own unless you had reason to trust him? That's why they have 2 keys to launch the nukes!

Well you can talk the talk but none of that squares with what you wrote in this thread where you went off and rewrote some stuff on your own

[SpontaneousOrder]

Not in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos. A good experienced developer knows when and where to use these valuable tools.

With any luck in an Agile team you'll only have 1 numpty out of 5 or 6 developers. Pair programming and rotating developers among different aspects of the code base (rather than having guys sitting in silos) should mean apart from getting a team with all-round knowledge of the system as a whole, you also get to keep some quality control.

You can still do the same on a non-agile project, so I'd suggest your example is more down to poor project management/company culture than anything else. Why would you let a single guy loose on his own unless you had reason to trust him? That's why they have 2 keys to launch the nukes!

[suityou01]

Not in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos.

And this is how you can make yourself indispensable.

[Unix]

Maybe because you're in charge now and don't let them maintain their own codebase?

Fortunately most projects I work on now are Agile, and the PM has no authority to dictate coding practises or to hire/fire from teams.
Interestingly, without someone ignorant of modern technologies & techniques sticking their oar in, the code tends to be of a very high quality.

Not in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos. A good experienced developer knows when and where to use these valuable tools.

[SpontaneousOrder]

we wrote working code with no defects, how come any time I ask for even the smallest change now, test teams always find bugs from guys like you that know it all.??

Maybe because you're in charge now and don't let them maintain their own codebase?

Fortunately most projects I work on now are Agile, and the PM has no authority to dictate coding practises or to hire/fire from teams.
Interestingly, without someone ignorant of modern technologies & techniques sticking their oar in, the code tends to be of a very high quality.