Code reviews

[NotAllThere]

Inheritance should be avoided at all costs.

Word to the wise, son. When you're in a hole, stop digging.

[d000hg]

You need your to inherit from your base class of single celled organism down through the layers to aquatic birds.

Or ToyDuck needs to inherit both Toy AND Duck.

That should set the cat amongst the pigeons. Or ducks.

[SpontaneousOrder]

we wrote working code with no defects, how come any time I ask for even the smallest change now, test teams always find bugs from guys like you that know it all.??

Maybe because you're in charge now and don't let them maintain their own codebase?

Fortunately most projects I work on now are Agile, and the PM has no authority to dictate coding practises or to hire/fire from teams.
Interestingly, without someone ignorant of modern technologies & techniques sticking their oar in, the code tends to be of a very high quality.

[Unix]

Maybe because you're in charge now and don't let them maintain their own codebase?

Fortunately most projects I work on now are Agile, and the PM has no authority to dictate coding practises or to hire/fire from teams.
Interestingly, without someone ignorant of modern technologies & techniques sticking their oar in, the code tends to be of a very high quality.

Not in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos. A good experienced developer knows when and where to use these valuable tools.

[suityou01]

Not in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos.

And this is how you can make yourself indispensable.

[SpontaneousOrder]

Not in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos. A good experienced developer knows when and where to use these valuable tools.

With any luck in an Agile team you'll only have 1 numpty out of 5 or 6 developers. Pair programming and rotating developers among different aspects of the code base (rather than having guys sitting in silos) should mean apart from getting a team with all-round knowledge of the system as a whole, you also get to keep some quality control.

You can still do the same on a non-agile project, so I'd suggest your example is more down to poor project management/company culture than anything else. Why would you let a single guy loose on his own unless you had reason to trust him? That's why they have 2 keys to launch the nukes!

[minestrone]

With any luck in an Agile team you'll only have 1 numpty out of 5 or 6 developers. Pair programming and rotating developers among different aspects of the code base (rather than having guys sitting in silos) should mean apart from getting a team with all-round knowledge of the system as a whole, you also get to keep some quality control.

You can still do the same on a non-agile project, so I'd suggest your example is more down to poor project management/company culture than anything else. Why would you let a single guy loose on his own unless you had reason to trust him? That's why they have 2 keys to launch the nukes!

Well you can talk the talk but none of that squares with what you wrote in this thread where you went off and rewrote some stuff on your own

[minestrone]

Word to the wise, son. When you're in a hole, stop digging.

"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.

[SpontaneousOrder]

Well you can talk the talk but none of that squares with what you wrote in this thread where you went off and rewrote some stuff on your own

I spent 2 or 3 hours working, and then my code was reviewed (and approved btw). How does that not square?

[SpontaneousOrder]

"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.

You mean "it usually ends up a mess" when used inappropriately? I'm not sure we should use yourself as the lowest common denominator of a developer's ability. Otherwise I'd better go and find a plastic lid with a spout on it for my coffee.