Originally posted by SpontaneousOrder
View Post
- Visitors can check out the Forum FAQ by clicking this link. You have to register before you can post: click the REGISTER link above to proceed. To start viewing messages, select the forum that you want to visit from the selection below. View our Forum Privacy Policy.
- Want to receive the latest contracting news and advice straight to your inbox? Sign up to the ContractorUK newsletter here. Every sign up will also be entered into a draw to WIN £100 Amazon vouchers!
Reply to: Code reviews
Collapse
You are not logged in or you do not have permission to access this page. This could be due to one of several reasons:
- You are not logged in. If you are already registered, fill in the form below to log in, or follow the "Sign Up" link to register a new account.
- You may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
- If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.
Logging in...
Previously on "Code reviews"
Collapse
-
Originally posted by SpontaneousOrder View PostAs we're on the topic of tulipy code and maintenance, etc - here's a gem of a javadoc for a class I just came across:
/**
* Retrieves disputed payments. Inaccurately named, since it is both
* used by the ixxxxxxxx and the xxxxxxxxx!
*
* @author xxxxxxxx
*/
Why don't people fix mistakes when they see them?!
Leave a comment:
-
As we're on the topic of tulipy code and maintenance, etc - here's a gem of a javadoc for a class I just came across:
/**
* Retrieves disputed payments. Inaccurately named, since it is both
* used by the ixxxxxxxx and the xxxxxxxxx!
*
* @author xxxxxxxx
*/
Why don't people fix mistakes when they see them?!
Leave a comment:
-
Originally posted by eek View Postbut that means you have to think. We want a simple answer which doesn't require thinking that we can take the mickey out of...
I meant that you should always inherit from a bass class and also add the base class as a member or you are clearly a cretin who should not be allowed near a keyboard - and NO! I don't care if you language does not support inheritance.
Leave a comment:
-
How about 'use inheritance when it is appropriate and use composition when it is appropriate'?
Leave a comment:
-
Originally posted by minestrone View Post"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.
Leave a comment:
-
Originally posted by minestrone View Post"favour composition over inheritance" but It is better that people are told just not to do it, it usually ends up a mess and adds only trouble. I would say most modern frameworks have all but stopped using inheritance as a means of integration.
Leave a comment:
-
Originally posted by minestrone View PostWell you can talk the talk but none of that squares with what you wrote in this thread where you went off and rewrote some stuff on your own
Leave a comment:
-
Originally posted by NotAllThere View PostWord to the wise, son. When you're in a hole, stop digging.
Leave a comment:
-
Originally posted by SpontaneousOrder View PostWith any luck in an Agile team you'll only have 1 numpty out of 5 or 6 developers. Pair programming and rotating developers among different aspects of the code base (rather than having guys sitting in silos) should mean apart from getting a team with all-round knowledge of the system as a whole, you also get to keep some quality control.
You can still do the same on a non-agile project, so I'd suggest your example is more down to poor project management/company culture than anything else. Why would you let a single guy loose on his own unless you had reason to trust him? That's why they have 2 keys to launch the nukes!
Leave a comment:
-
Originally posted by Unix View PostNot in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos. A good experienced developer knows when and where to use these valuable tools.
You can still do the same on a non-agile project, so I'd suggest your example is more down to poor project management/company culture than anything else. Why would you let a single guy loose on his own unless you had reason to trust him? That's why they have 2 keys to launch the nukes!
Leave a comment:
-
Originally posted by Unix View PostNot in my experience, depends on the team. The project I am working on was written by a chap who over engineered the code with over use of interfaces, inheritance, dependency injection etc that it takes as long to grep as if it were procedural spaghetti code with gotos.
Leave a comment:
-
Originally posted by SpontaneousOrder View PostMaybe because you're in charge now and don't let them maintain their own codebase?
Fortunately most projects I work on now are Agile, and the PM has no authority to dictate coding practises or to hire/fire from teams.
Interestingly, without someone ignorant of modern technologies & techniques sticking their oar in, the code tends to be of a very high quality.
Leave a comment:
-
Originally posted by tarbera View Postwe wrote working code with no defects, how come any time I ask for even the smallest change now, test teams always find bugs from guys like you that know it all.??
Fortunately most projects I work on now are Agile, and the PM has no authority to dictate coding practises or to hire/fire from teams.
Interestingly, without someone ignorant of modern technologies & techniques sticking their oar in, the code tends to be of a very high quality.
Leave a comment:
- Home
- News & Features
- First Timers
- IR35 / S660 / BN66
- Employee Benefit Trusts
- Agency Workers Regulations
- MSC Legislation
- Limited Companies
- Dividends
- Umbrella Company
- VAT / Flat Rate VAT
- Job News & Guides
- Money News & Guides
- Guide to Contracts
- Successful Contracting
- Contracting Overseas
- Contractor Calculators
- MVL
- Contractor Expenses
Advertisers
Contractor Services
CUK News
- Streamline Your Retirement with iSIPP: A Solution for Contractor Pensions Sep 1 09:13
- Making the most of pension lump sums: overview for contractors Sep 1 08:36
- Umbrella company tribunal cases are opening up; are your wages subject to unlawful deductions, too? Aug 31 08:38
- Contractors, relabelling 'labour' as 'services' to appear 'fully contracted out' won't dupe IR35 inspectors Aug 31 08:30
- How often does HMRC check tax returns? Aug 30 08:27
- Work-life balance as an IT contractor: 5 top tips from a tech recruiter Aug 30 08:20
- Autumn Statement 2023 tipped to prioritise mental health, in a boost for UK workplaces Aug 29 08:33
- Final reminder for contractors to respond to the umbrella consultation (closing today) Aug 29 08:09
- Top 5 most in demand cyber security contract roles Aug 25 08:38
- Changes to the right to request flexible working are incoming, but how will contractors be affected? Aug 24 08:25
Leave a comment: