numpty sftp question

[Pondlife]

I have a script that I want to use to put multiple files via sftp.
The script is as follows (from memory )

#!/bin/bash

myftpuser=”blahftp”
myftpserver=”blahblah.dyndns.org"

touch sftp_batch
for files in `ls -1 $1` 
do
{
echo "put $files" >> sftp_batch
}
done
echo "quit" >> sftp_batch

sftp -b sftp_batch $myftpuser@$myftpserver

rm sftp_batch

When I run the first script and pass a directory as parameter the sftp_batch file created looks like;

put file1
put file2
put filex
quit


Which is what I expected.

BUT it only puts the first file on the server.

WTF am I missing?

Local box is Mac, sftp server is Ubuntu, no issues with authentication or connectivity as the first file goes across fine.

TIA Pondy.

[Pondlife]

I'm such a knobhead.

Was missing a. echo "lcd $1" line in the file.

All works now.