Originally posted by Ardesco
View Post
- Visitors can check out the Forum FAQ by clicking this link. You have to register before you can post: click the REGISTER link above to proceed. To start viewing messages, select the forum that you want to visit from the selection below. View our Forum Privacy Policy.
- Want to receive the latest contracting news and advice straight to your inbox? Sign up to the ContractorUK newsletter here. Every sign up will also be entered into a draw to WIN £100 Amazon vouchers!
Reply to: More Critique Please
Collapse
You are not logged in or you do not have permission to access this page. This could be due to one of several reasons:
- You are not logged in. If you are already registered, fill in the form below to log in, or follow the "Sign Up" link to register a new account.
- You may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
- If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.
Logging in...
Previously on "More Critique Please"
Collapse
-
-
Looks fine to me in Firefox 3.5.7 and Chrome 4.0.249.43 running on Linux.
Leave a comment:
-
Thanks NF, as helpful as ever
The IE6 warning thing is actually this:
http://code.google.com/p/sevenup/
Just can't find the javascript snippets these days hey... I'll prolly just grab another one so that I don't have to think about it.
Leave a comment:
-
The overall structure of the page looks good without styles.
The alt attribute of the shopping basket should be "View shopping basket", not "Shopping basket icon"; however, at the moment it's outside the link, so clicking on it does nothing. Best thing though is to move it inside the link and set the alt attribute to "", as it becomes superfluous when the link text contains all the information required. (You can't just leave the attribute out though, you have to set it to the empty string.)
There shouldn't be a "label" element around the shopping basket link: "label" is for associating text with form controls, not links. At the moment, you're using the "label" to hang some styles on, such as setting the cursor and underlining on hover. Once the icon is inside the link you can set those styles on "a:hover" instead. If you still need an enclosing element for styling purposes, a "span" would be appropriate (not a "div" as you're inside a "p", and only inline elements are allowed), but I reckon you can probably manage without one by rejigging the styles slightly.
Rather than having an "a" around the "Remember me" checkbox and its associated "label", you could wrap the "label" around the checkbox and the text, and style that. If you need to add some additional styling to the text but not the checkbox, it could be wrapped in a "span".
In the "Support" table, the cell containing the text "Support online" should be a "th" rather than a "td", as it is the heading for the other cells. (You may then need to override the default browser styles for "th" such as bold text.) Furthermore, give it a "rowspan" attribute of "4" and remove the empty cells at the start of the remaining three rows: then that heading will be associated with all the data, rather than just the first row.
On IE6, the message telling me that my browser is outdated is broken
You're using the "#nav > li" child selector to set styles on the navigation list; this of course won't work on IE6. Unless you're planning on having nested lists, you could just use the descendant selector "#nav li", although if you do plan to have nested lists you then finish up having to use "#nav li li" to override styles on them. Still, that could go in your IE6 stylesheet.
That's all for now; I'll try to find time to have another look at the IE6 issues at some point, but I'll have to set up one of my debugging proxies to really get into it, and I ought to be making my dinner instead
Leave a comment:
-
Originally posted by Zippy View PostI'm using FF3.0.5
Home page
-----------
The text in the second and third columns is overwriting the images. It looks a bit odd and makes it hard to find the "comments" links in the text.
The tab between "Teamspeak Admin" and "Contact Sales" is missing
I'd be inclined to add underlining when you hover over the LH menu options
If you try to log in with rubbish details you get a "Bad Request" message (I appreciate you may not have got round to this yet). I'd suggest all non-functional links are redirected to a holding page. It helps to be tidy
Red underlining on the Subscribe option - nooo. Not enough contrast for me. I don't think yellow/grey on the menu options is a good enough contrast either.
You need to be putting alt text on your images
I'm sure NickFitz will be along soon, but I hope this helps a bit.
By the second and third columns do you mean the featured blocks? (i.e. one is red with an image of the website and black text that is not too readable at the moment, and one is black with white text)
As for alt tags, they are all there (unless I've missed something). The markup should all be compliant and pass any W3C validation checks.
Leave a comment:
-
Originally posted by NickFitz View Posttomorrow
Until then, WSS about the alt attribute; and remember that the alt attribute is intended to be used when the image cannot be seen - this isn't necessarily the same thing as describing the image
Leave a comment:
-
Originally posted by Zippy View PostYou need to be putting alt text on your images
I'm sure NickFitz will be along soon, but I hope this helps a bit.
Until then, WSS about the alt attribute; and remember that the alt attribute is intended to be used when the image cannot be seen - this isn't necessarily the same thing as describing the image
Leave a comment:
-
I'm using FF3.0.5
Home page
-----------
The text in the second and third columns is overwriting the images. It looks a bit odd and makes it hard to find the "comments" links in the text.
The tab between "Teamspeak Admin" and "Contact Sales" is missing
I'd be inclined to add underlining when you hover over the LH menu options
If you try to log in with rubbish details you get a "Bad Request" message (I appreciate you may not have got round to this yet). I'd suggest all non-functional links are redirected to a holding page. It helps to be tidy
Red underlining on the Subscribe option - nooo. Not enough contrast for me. I don't think yellow/grey on the menu options is a good enough contrast either.
You need to be putting alt text on your images
I'm sure NickFitz will be along soon, but I hope this helps a bit.
Leave a comment:
-
Originally posted by Ardesco View PostThose top boxes are going to be unique graphics each time, the one there at the moment happens to be red, but no guarantee that they will always look like that. (I have a mainly black one that will take one of those spots, and it could be anything in the future).
(Just updated it so it shows a black one and a red one)
One other point, the menu on the left (Game List, Server Prices etc) should, for symmetry, be the same height as the boxes we have been talking about.
Failing that, it should fill all of the height of the dark grey area it currently sits in - at the moment, it doesn't seem to be very well positioned.
Just my tuppence worth.
Leave a comment:
-
Those top boxes are going to be unique graphics each time, the one there at the moment happens to be red, but no guarantee that they will always look like that. (I have a mainly black one that will take one of those spots, and it could be anything in the future).
(Just updated it so it shows a black one and a red one)
Leave a comment:
-
Originally posted by Ardesco View PostGetting closer with this now:
http://test.lazeryattack.co.uk/
Things to do at the moment:
- Set up a tab path
- Fix IE6 (knackered atm, thinking of just disabling stylesheets for it... )
- Text Colour on featured items block (Where it says new look and feel)
Its only the main homepage atm
Wrt the point in your list above (highlighted), the text is not easy to read because it goes across the image of the screenshot. IMHO, you should re-format so it stays within the red box.
Personally, I think the red boxes at the top should be amended to match the boxes on the right hand side so that they have a red accent at the top of the box instead of being completely red. Will 'soften' the site for users eyes.
Hope my comments make sense.
Leave a comment:
-
More Critique Please
Getting closer with this now:
http://test.lazeryattack.co.uk/
Things to do at the moment:
- Set up a tab path
- Fix IE6 (knackered atm, thinking of just disabling stylesheets for it... )
- Text Colour on featured items block (Where it says new look and feel)
Its only the main homepage atmTags: None
- Home
- News & Features
- First Timers
- IR35 / S660 / BN66
- Employee Benefit Trusts
- Agency Workers Regulations
- MSC Legislation
- Limited Companies
- Dividends
- Umbrella Company
- VAT / Flat Rate VAT
- Job News & Guides
- Money News & Guides
- Guide to Contracts
- Successful Contracting
- Contracting Overseas
- Contractor Calculators
- MVL
- Contractor Expenses
Advertisers
Contractor Services
CUK News
- Streamline Your Retirement with iSIPP: A Solution for Contractor Pensions Sep 1 09:13
- Making the most of pension lump sums: overview for contractors Sep 1 08:36
- Umbrella company tribunal cases are opening up; are your wages subject to unlawful deductions, too? Aug 31 08:38
- Contractors, relabelling 'labour' as 'services' to appear 'fully contracted out' won't dupe IR35 inspectors Aug 31 08:30
- How often does HMRC check tax returns? Aug 30 08:27
- Work-life balance as an IT contractor: 5 top tips from a tech recruiter Aug 30 08:20
- Autumn Statement 2023 tipped to prioritise mental health, in a boost for UK workplaces Aug 29 08:33
- Final reminder for contractors to respond to the umbrella consultation (closing today) Aug 29 08:09
- Top 5 most in demand cyber security contract roles Aug 25 08:38
- Changes to the right to request flexible working are incoming, but how will contractors be affected? Aug 24 08:25
Leave a comment: