cobol copybook

[ASB]

Those level 01s really should have been level 77s. And should that customer number really have been alphanumeric and not numeric?


(I've got grey sideburns. Can you tell?)

From a language point of view the 01 v 77 is a valid arguable style point. However in a number of compilers there is good reason for using 01 rather than 77 related to the code that is produced.

Equally the first 4 items (assuming they are indeed constant) could have been defined as a level 78 (if supported by the compiler) or they could have been defined in the constant section (if supported by the compiler in question).

CREC should probably also be a typedef (if supported)

The code of the main program fails the full ANSI '85 syntax check as well for at least 1 reason (no data division - and it never was optional if any of the sections were used). If memory serves the standard did make the environment division optional.

Far too many bloody variations. Post 85 standard everybody has gone their own way a bit.

Anyway I could update it all to object cobol in no more than 250 lines of new code. There's progress.....

[RichardCranium]

* copybook INQINTC
* Channel name
01 INQUIRY-CHANNEL PIC X(16) VALUE 'inqcustrec'.
* Container names
01 CUSTOMER-NO PIC X(16) VALUE 'custno'.
01 BRANCH-NO PIC X(16) VALUE 'branchno'.
01 CUSTOMER-RECORD PIC X(16) VALUE 'custrec'.
* Define the data fields used by the program
01 CUSTNO PIC X(8).
01 BRANCHNO PIC X(5).

Those level 01s really should have been level 77s. And should that customer number really have been alphanumeric and not numeric?


(I've got grey sideburns. Can you tell?)

[Archangel]

PM Sent

[cojak]

BTW Does anyone know what happened to JJ Le Burt? I had his bible for Cobol II and Cobol 3 but he didn't write anymore - I waited for later versions but they didn't appear...

[cojak]

Flippin' heck! That brings back memories!

But aren't we talking COBOL V+ these days? Even I was working in COBOL III before I finished...

[darmstadt]

* copybook INQINTC
* Channel name
01 INQUIRY-CHANNEL PIC X(16) VALUE 'inqcustrec'.
* Container names
01 CUSTOMER-NO PIC X(16) VALUE 'custno'.
01 BRANCH-NO PIC X(16) VALUE 'branchno'.
01 CUSTOMER-RECORD PIC X(16) VALUE 'custrec'.
* Define the data fields used by the program
01 CUSTNO PIC X(8).
01 BRANCHNO PIC X(5).
01 CREC.
02 CUSTNAME PIC X(80).
02 CUSTADDR1 PIC X(80).
02 CUSTADDR2 PIC X(80).
02 CUSTADDR3 PIC X(80).

IDENTIFICATION DIVISION.
PROGRAM-ID. CLIENT1.

WORKING-STORAGE SECTION.

COPY INQINTC

PROCEDURE DIVISION.
MAIN-PROCESSING SECTION.

VS/COBOL II

[ASB]

What kind of tips? It's just COBOL.

I suppose it's even more important to use a unique prefixing system for all field names, to avoid duplication, but you should be doing that anyway.

Copy replacing - if supported by the compiler in question.

[expat]

Any help or tips on writing a .cpy file?

What kind of tips? It's just COBOL.

I suppose it's even more important to use a unique prefixing system for all field names, to avoid duplication, but you should be doing that anyway.

[Platypus]

Find a working one and use it as a template

[Pogle]

Any help or tips on writing a .cpy file?