Code reviews

[suityou01]

That was the final straw for me too. I took this gig because i needed to earn some money, but next time i'll hopefully have the luxury of being more picky.

So why not maximise the potential of money earning by communicating your ideas before you implement them?

[Platypus]

So why not maximise the potential of money earning by communicating your ideas before you implement them?

Ah suity, whenever I think you of, this comes to mind

[EternalOptimist]

First rule of contracting, let someone else take the glory while you take the money.
If you cant make it so simple that the permies cant take credit, dont do it

[d000hg]

Does anyone else experience dismay from permies code reviewing your code similar tho this?

I work on a fixing something in their 5 method, 1 thousand line Java source file, and in the process end up splitting it up into 3 or 4 extra classes, with all of the new classes tested and in total now more like 25 - 30 methods so that you can actually read the code in english instead of needing to learn to read the matrix.

Looks of dismay at code review time - apparently i've made the code more complicated!

If you are making a small bug fix and you totally refactor the code, I'd be pissed off too. That's not what you were asked to do, or what you are being paid for. You should raise the issue separately.

Otherwise you risk the situation where every developer refactors every file they work on to their own tastes each time.

[d000hg]

Sometimes fixing the bug requires refactoring the program. There can be more risk in fixing a bad program than rewriting it to a reasonable standard.

Sometimes yes, or at least it's worth it because the changes are big. But typically a bug-fix doesn't require or justify wholesale refactoring.

[Bellona]

First rule of contracting, let someone else take the glory while you take the money.
If you cant make it so simple that the permies cant take credit, dont do it

If you are making a small bug fix and you totally refactor the code, I'd be pissed off too. That's not what you were asked to do, or what you are being paid for. You should raise the issue separately.

Otherwise you risk the situation where every developer refactors every file they work on to their own tastes each time.

These guys have nailed it

[EternalOptimist]

These guys have nailed it

and dont forget

make hay while the sun shines
but look before you leap

[d000hg]

Not to mention

A bird's bush is worth one in the hand.

[EternalOptimist]

Not to mention

A bird's bush is worth one in the hand.

ah yes, but
many hands make light work
whilst too many cooks spoil the broth

[MyUserName]

ah yes, but
many hands make light work
whilst too many cooks spoil the broth

A fool and his money are soon partying.