Code reviews

[minestrone]

He's of the old school. Nothing wrong with that as long as nobody hires him to work on a project using modern methodologies or languages.

WTF are you talking about?

I am advocating OO interface class design over internal method logic and you are asking if I am a C developer. You can't even follow the way the discussion is going.

[minestrone]

FTFY

You have some cheek talking about professionalism, you are in here every few months after being kicked from a job crying as money is too tight to feed the kids.

[SpontaneousOrder]

Yes if you discount my 15 years as a hard nosed coder in RPG II, III, ILE...

So nothing particularly relevant to the discussion then.
I guess I was right!

[suityou01]

You have some cheek talking about professionalism, you are in here every few months after being kicked from a job crying as money is too tight to feed the kids.

And one of those little donuts, with the multi coloured sprinkles on the top. Off ye pop.

[SpontaneousOrder]

Almost all IDE's/editors allow you to easily navigate between method calls. Code becomes much more readable when you have smaller methods that are properly named i.e.

if (isCardVerified()) {

//do stuff
}

rather than repeating the perhaps complex code inside isCardVerified every time.

Right. Even then you can generally just write the private methods underneath the public one which uses them, in the order they are used - so you don't even need the IDE's help with that. Then when you're not working you way through that particular bit of code, the IDE can sort your methods A-Z or by visibility or whatever, so there's no worry with regards to having to find your public methods mixed in with private ones (if you prefer it that way, which I do).

[suityou01]

Right. Even then you can generally just write the private methods underneath the public one which uses them, in the order they are used - so you don't even need the IDE's help with that. Then when you're not working you way through that particular bit of code, the IDE can sort your methods A-Z or by visibility or whatever, so there's no worry with regards to having to find your public methods mixed in with private ones (if you prefer it that way, which I do).

No, no, no, no. You have to expose everything through an interface. The class musn't hide anything. Encapsulation is soooo last year daaaaahlink.

[SpontaneousOrder]

Clearly you client has seen what you have done and though the same, else you would not be on here pissing your knickers about getting slated at code review time and looking for some affirmation which you only seem to be getting from the assorted cretins clique of CUK.

No knicker pissing. I just posted to publicly roll my eyes, and ask how other's deal with working with incompetents while only being onsite for the short term.

Besides, the negative comments (apart from yours) are with regards to possibly working outside my remit - not the virtues, or not, of writing clean code.

You're embarrassing yourself and should stop. Your time would be better spent checking out the vacancies board at your local Tesco.

[d000hg]

WTF are you talking about?

I am advocating OO interface class design over internal method logic and you are asking if I am a C developer. You can't even follow the way the discussion is going.

Because you sound like a C programmer who was pushed into C++/Java and never really understood the paradigm shift. Doing everything through public methods is basically just C anyway.

[SpontaneousOrder]

For anything non-super trivial, the only way you can get away with only having public methods is to ignore encapsulation completely and just make all your would-be private methods public, OR you have to duplicate code all over the place.

One of those is just dumb, and the other would prompt me to ask why you were even using Java in the first place?

[minestrone]

For anything non-super trivial, the only way you can get away with only having public methods is to ignore encapsulation completely and just make all your would-be private methods public, OR you have to duplicate code all over the place.

One of those is just dumb, and the other would prompt me to ask why you were even using Java in the first place?

How in gods name does only using public methods break encapsulation?

You are just speaking complete mince now love.