Day 53: How to deal with an eager beaver

[suityou01]

I can tell that he's determined to make his mark by pulling apart all my meticulously implemented JavaScript for that reason alone.

That really wouldn't make me very happy....

If something works is there a reason to pull it apart? Why not drop the phrase "there are a thousand ways to implement something. As long as it's readible, maintainable and fit for purpose then I'm sure the client won't give extra points for artistic license, nor appreciate burning the extra pounds".

[SimonMac]

I can tell that he's determined to make his mark by pulling apart all my meticulously implemented JavaScript for that reason alone.

That really wouldn't make me very happy....

Is he finding issues with your code? If no tell him to **** off, if yes tell him you are sorry

[OwlHoot]

I can tell that he's determined to make his mark by pulling apart all my meticulously implemented JavaScript for that reason alone.

That really wouldn't make me very happy....

Oh dear - a wheel reinventor or, in other words one of the "self-conceited brethren, who run their own ways, and give liking unto nothing but what is framed by themselves, and hammered on their own anvil"

Yes, you can do without one of them.

[zoco]

Is he finding issues with your code? If no tell him to **** off, if yes tell him you are sorry

He has some magic all singing and dancing div apparently that, when coupled with some generic api that he's written, will solve all the problems I've already sorted out using jquery and css.

[zoco]

Oh dear - a wheel reinventor or, in other words one of the "self-conceited brethren, who run their own ways, and give liking unto nothing but what is framed by themselves, and hammered on their own anvil"

Yes, you can do without one of them.

Yes, that's it..

[CheeseSlice]

Oh dear ™

Aren't you supposed to say "Crumbs" with that avatar?

[zoco]

What he doesn't like is this :

I have a user control with up to 20 columns which may or not be visible depending on what tab of a tab control is active.

There are many possible combinations and none of it is particularly symmetrical so it's not just a question of toggling visibility.

What Ive done is assign a bit mask value to each tab and do bit wise operations to determine whether each column should be shown or hidden. That way, I just have 5 numbers and one simple function to maintain.

He seems to think this is old hat and is dying to plug in his magic div.

[suityou01]

Does he understand what you have done?

[zoco]

Does he understand what you have done?

No but he's supposed to be a style/CSS guy. I would argue that logic surrounding what to show and what not to show isn't really in his remit as a lot of it is entwined in the business logic. But it's a grey area...

[eek]

What he doesn't like is this :

I have a user control with up to 20 columns which may or not be visible depending on what tab of a tab control is active.

There are many possible combinations and none of it is particularly symmetrical so it's not just a question of toggling visibility.

What Ive done is assign a bit mask value to each tab and do bit wise operations to determine whether each column should be shown or hidden. That way, I just have 5 numbers and one simple function to maintain.

He seems to think this is old hat and is dying to plug in his magic div.

It seems that neither of you are aware that the final code just using DIVs in the background to hide/show those columns.....

So both of you are right and wrong so accept it and move onwards.....