Just spent hours chasing down a bug

[DimPrawn]

Symptoms were that all the data in one table was being updated with the same values.

Been going round in circles.

Then saw the following SQL lurking amongst a ton of other SQL:

UPDATE tableName
SET col1 = @col1,
col2 = @col2,
col3 = @col3
etc
WHERE primaryKey = primaryKey;


The missing @ on primaryKey parameter!



In the old days before senility and long term alcohol abuse I would have spotted that in seconds.

[BrilloPad]

You should have posted the code on here. With thread title "spot the bug competition".

[AtW]

Stick to VB.NET...

[DimPrawn]

I couldn't see the wood for the trees. No matter how many times I looked at the update, I didn't see the missing @.

Time to retire.

[EternalOptimist]

i dont understand why you have such naff column names.
col1, col2, col3

is it a database for Colins Cauliflower Collective in Colchester or something

[Weltchy]

I'm surprised the etc in the middle of your SQL Statement worked!!

[MrMark]

The best sql update issue is where you update a (few) record(s) based on records from another table. If you're not careful you can update all the records.

[Andy2]

Rookie mistake by newbies

[MrMark]

I'm surprised the etc in the middle of your SQL Statement worked!!

It's a surprisingly good name for a function call!

[TimberWolf]

Easy mistake to make. Perhaps it's worth prefixing parameter variables? Same with method parameters, because one day it will trip you up?