Beginners C#query

[doodab]

Terrible, terrible code.

I know exactly why it is done though as they are thinking...

using (StreamReader sr = new StreamReader(args[0]))
{
while ( sr.ReadLine() !=null) {
iRows++;
Console.WriteLine(iRows + " - " + sr.ReadLine() );
}
}

involves 2 method calls and they figure that dumping the contents of the call into a variable and using that next is quicker. All balls of course but they think that is how it works. See that kind of tulip everyday sadly.

Or thinking that the first readline reads a line that gets thrown away so they had better keep it. Of course they don't know about peek.

Though people writing all C syntax languages like they are C annoys me, that idiom is one I'd keep as it's succinct and common enough that people know what it does.

[minestrone]

Or thinking that the first readline reads a line that gets thrown away so they had better keep it. Of course they don't know about peek.

Though people writing all C syntax languages like they are C annoys me, that idiom is one I'd keep as it's succinct and common enough that people know what it does.

I think you are right...

Don't know C# but that would be a..

using (StreamReader sr = new StreamReader(args[0])) {
String zeString = sr.ReadLine() ;
while ( zeString !=null) {
Console.WriteLine(iRows++ + " - " + zeString );
}
}

from me

[doodab]

while ( sr.Peek() > -1) {
Console.WriteLine(iRows++ + " - " + sr.ReadLine());
}
}

might terminate quicker

[minestrone]

Did not know of this peek call.

I would have written...

Console.WriteLine( new StreamReader(args[0]) );

...and told them if they want the splodge of text formatted into some kind of readable text it would be another 2 days work.

Kerching.

[RasputinDude]

Not in that context.

iRows is going to be the same with ++ .

The result will be the same, but ++iRows and iRows++ are different operations.


Actually, looking it into the MSIL a bit, it seems that they bother deliver the same results, which shows a real difference between C++ and C#. I'll research further when I have sobered up.

But I still think that ++iRows is better. ;-)

[minestrone]

The result will be the same, but ++iRows and iRows++ are different operations.

The next line don't care.

[RasputinDude]

It's not about the next line though, is it? it's about the most efficient method of incrementing something. Granted in C# land, it's not really an issue, but I also spend a lot of time in very memory and processor restricted C/C++ land where every cycle saved is still a bonus.

Anyway, I have granted above that in C#, it doesn't seem to make much difference, so I'll accept that in this case you are right. In this context, it doesn't matter.

[VectraMan]

The result will be the same, but ++iRows and iRows++ are different operations.


Actually, looking it into the MSIL a bit, it seems that they bother deliver the same results, which shows a real difference between C++ and C#. I'll research further when I have sobered up.

But I still think that ++iRows is better. ;-)

For a single line statement I think compilers are clever enough to do the same for ++i and i++. But there's still the odd nutter that thinks it's important and moan if you use i++ (which I nearly always do as it's clearer).

Of course the language should have been ++C and not C++.

[RasputinDude]

Yup, most compilers are.

But I'm old school and would prefer to see:

if (1 == i)

rather than

if (i == 1)


And yes, it should have been ++C

[minestrone]

Human readable code over compiler friendly code every day of the week.