Code reviews

[d000hg]

What a depressing thread. You should only do exactly as you are instructed and show no thought or initiative at all?

My view was always that you should leave code better than you found it. If you can make simple refactorings such as pulling methods to improve readability, reuse, testablity then its basically your responsibility as a professional to do that.

Simple refactorings are fine. Totally refactoring the whole class is not. It's not about lack of initiative, it's about knowing what is worth doing, and communication. If you are assigned to make a small fix and the reviewer is confronted with hundreds of lines of changed code, they have to spend extra time checking you didn't screw something up.

If you get an understanding that you will do this kind of thing as part of your contract then it's fine, but blundering in without even warning someone is the trademark of a wet behind the ears over-enthusiastic graduate.

[minestrone]

Lot of decorating references being bandied about. Not sure folks get what refactoring is. For the absence of doubt, refactoring into x classes is the DIY equivalent of gutting the interior, putting in a new stair case, wiring, plumbing, and the testing and commissioning would be the decorating part in my mind.

HTH

You clearly don't understand the context the references were made in, which is no surprise really.

[MyUserName]

Lot of decorating references being bandied about. Not sure folks get what refactoring is. For the absence of doubt, refactoring into x classes is the DIY equivalent of gutting the interior, putting in a new stair case, wiring, plumbing, and the testing and commissioning would be the decorating part in my mind.

HTH

You can not decorate references as by definition they are immutable.

[suityou01]

You clearly don't understand the context the references were made in, which is no surprise really.

Hackers need stay out of this old son. Leave this to the grown ups there's a good lad.

[suityou01]

You can not decorate references as by definition they are immutable.

If you hard code your dependencies, yes. Have a look at dependency injection.

HTH

[tarbera]

If you had done this on one of my projects

you would have been terminated immediately and escorted from the building, and sued for fecking up working code that only needed a 1 line fix, have you any idea the TESTING requirements you would have fecked up ???

Schoolboy error

[minestrone]

Hackers need stay out of this old son. Leave this to the grown ups there's a good lad.

Suity, we seen you on here asking for help and struggling for a week trying to get a connection to an oracle database.

Your technical skills have been demonstrated to be sub bob.

[MyUserName]

If you hard code your dependencies, yes. Have a look at dependency injection.

HTH

No thanks, too difficult for me. I will stick to abstract C++ jokes.

[suityou01]

Suity, we seen you on here asking for help and struggling for a week trying to get a connection to an oracle database.

Your technical skills have been demonstrated to be sub bob.

When? Times, places, posts. J'accuse.

[suityou01]

No thanks, too difficult for me. I will stick to abstract C++ jokes.

DI is equally applicable (and probably first implemented in) C++.