Code reviews

[d000hg]

you would have been terminated immediately and escorted from the building, and sued for fecking up working code that only needed a 1 line fix, have you any idea the TESTING requirements you would have fecked up ???

Schoolboy error

Which testing requirements?

Terminated immediately is as bad as the OP. The whole point of source control is you simply tell them in no uncertain terms "thanks for the intention, but please revert this and make the changes needed only".

[suityou01]

Brilliant thread sorting out the pros from the charlatans. Doogie your stocks are rising.

[tarbera]

ahhhh sir

Which testing requirements?

Terminated immediately is as bad as the OP. The whole point of source control is you simply tell them in no uncertain terms "thanks for the intention, but please revert this and make the changes needed only".

Wow are you an accountant.?

Starter for 1, Performance testing for example might cost the project 150K to retest and get certified for use in a live environment of all these changes. Old code might wizz like a dream (but hard to read).

[vwdan]

Wow are you an accountant.?

Starter for 1, Performance testing for example might cost the project 150K to retest and get certified for use in a live environment of all these changes. Old code might wizz like a dream (but hard to read).

I think the point d00hg is making is that, apart from time lost, all that should happen is a quick conversation about how they preferred the old code for [reasons], and a quick rollback if the changes have been committed to the repository.

[minestrone]

Change something that you were not asked to change and then it is possible to be sued if you cause chaos, that is why you should carry insurance and I don't know why people are scoffing at the suggestion.

[d000hg]

Wow are you an accountant.?

Starter for 1, Performance testing for example might cost the project 150K to retest and get certified for use in a live environment of all these changes. Old code might wizz like a dream (but hard to read).

If you are changing the file AT ALL then the same performance tests would be needed. And it would be automated.

Like to try again?

[suityou01]

If you are changing the file AT ALL then the same performance tests would be needed. And it would be automated.

Like to try again?

[tarbera]

Rubbish !!!!

If you are changing the file AT ALL then the same performance tests would be needed. And it would be automated.

Like to try again?

So a change in a variable name requires same performance testing as breaking a 1000 line program into 15 sub procedures -

Hope you’re a coder and not a PM

[d000hg]

And which poor sod goes through every single file change deciding if it's worthy of re-running these oh-so-valuable tests, which cost the same as 3-4 permie annual salaries?

I'd ask if you were a PM, but your total lack of understanding of anything technical makes the answer pretty obvious.

[tarbera]

lol

And which poor sod goes through every single file change deciding if it's worthy of re-running these oh-so-valuable tests, which cost the same as 3-4 permie annual salaries?

I'd ask if you were a PM, but your total lack of understanding of anything technical makes the answer pretty obvious.

The poor sod who has had to fire the out of control new programmer 'Who knows best' but knows nothing.