Code reviews

[MyUserName]

How in gods name does only using public methods break encapsulation?

You are just speaking complete mince now love.

Possibly he meant methods and data?
As in to make all methods and data public would break encapsulation.

[SpontaneousOrder]

How in gods name does only using public methods break encapsulation?

You are just speaking complete mince now love.

I can't answer that question. You just asked me 'why is water wet?'

[Unix]

For anything non-super trivial, the only way you can get away with only having public methods is to ignore encapsulation completely and just make all your would-be private methods public, OR you have to duplicate code all over the place.

One of those is just dumb, and the other would prompt me to ask why you were even using Java in the first place?

You can still have encapsulation with public methods, the caller of your public method doesn't know or care how you implement the method, as long as the signature never changes. Encapsulation to me more about the internal state of the object being hidden, so private variables etc.

[SpontaneousOrder]

Possibly he meant methods and data?
As in to make all methods and data public would break encapsulation.

Putting a public accessor/mutator in front of private data doesn't magically make it encapsulated either.

[MyUserName]

Putting a public accessor/mutator in front of private data doesn't magically make it encapsulated either.

So making all private data public would break encapsulation? Isn't that what I said?

[suityou01]

Possibly he meant methods and data?
As in to make all methods and data public would break encapsulation.

So making all private data would break encapsulation? Isn't that what I said?

Pick one

[SpontaneousOrder]

You can still have encapsulation with public methods, the caller of your public method doesn't know or care how you implement the method, as long as the signature never changes. Encapsulation to me more about the internal state of the object being hidden, so private variables etc.

Exactly - so for anything but the simplest class imaginable, if you don't want to duplicate code all over the place you will have smaller reusable methods. Those methods are not meant to be exposed to the outside world because they are for manipulating the internal state.
So if you make them public you are breaking encapsulation because the outside world is now not restricted to interact via the appropriate public api; now they can **** about with the internal state of that object unrestricted.

[d000hg]

So he's of the "C with classes" school?

[SpontaneousOrder]

So making all private data would break encapsulation? Isn't that what I said?

Sorry, i think i've misunderstood. I don't know what you are asking?

[MyUserName]

Pick one

DOH!!!! Sorry have fixed it, well spotted!!