Properties Vs Methods (.Net)

[wurzel]

Is it bad form to stick loads of logic in a property getter? I personally think it is because semantically it obfuscates any logic plus the fact my debugger doesn't seem to like stepping into them. I've got one here that's got 200 lines of frikkin code behind it FFS & it's taken me nearly an hour to work out that this damn property is doing so much & is the root of all my problems!

 

[Spacecadet]

My first commercial dev job - functions had to be less than 1 page long (about 30-40 lines)

 

[AtW]

My first commercial dev job - functions had to be less than 1 page long (about 30-40 lines)

What about maximum file size (in lines)?

 

[NickFitz]

Is it bad form to stick loads of logic in a property getter? I personally think it is because semantically it obfuscates any logic plus the fact my debugger doesn't seem to like stepping into them. I've got one here that's got 200 lines of frikkin code behind it FFS & it's taken me nearly an hour to work out that this damn property is doing so much & is the root of all my problems!

Not so much "bad form" as "gross incompetence"

 

[HairyArsedBloke]

You guys have just reminded me of one place where their was someone who hated contractors and would do code evaluations by using a cyclic complexity program he had written at uni. He was always sending stuff back as being too complex. His justification was that contractors code had to be simpler as they will leave and complex code will mean the permies will spend more time understanding the code, etc.

We got hold of his prog one day and found that simple things like bunching code into artificial functions will drop the complexity. So there were loads of funcs like void complexfunc() { partA(); partB(); partC(); partD(); }

One other thing, I think this guy was Bob Shawadiwadi's dad or uncle.

 

[wurzel]

Not so much "bad form" as "gross incompetence"

I think I should point out that this monstrosity was not my own handiwork!

 

[Zippy]

I think I should point out that this monstrosity was not my own handiwork!

Of course it wasn't

 

[NickFitz]

I think I should point out that this monstrosity was not my own handiwork!

I assumed that was the case, given that it took you an hour to work out that it was causing the problems - if you were the one who'd written it you'd still be trying to work out what was wrong, and probably claiming that it must be a bug in the OS

 

[Drewster]

I assumed that was the case, given that it took you an hour to work out that it was causing the problems - if you were the one who'd written it you'd still be trying to work out what was wrong, and probably claiming that it must be a bug in the OS

Good shot Sir!